Re: [RESEND PATCH] MIPS: ftrace: Declare ftrace_get_parent_ra_addr() as static

On Sun, 5 Jan 2025 17:37:47 +0900
Masami Hiramatsu (Google) [off-list ref] wrote:

On Sat,  4 Jan 2025 22:47:08 +0800
WangYuli [off-list ref] wrote:

quoted

Declare ftrace_get_parent_ra_addr() as static to suppress clang
compiler warning that 'no previous prototype'. This function is
not intended to be called from other parts.

Fix follow error with clang-19:

arch/mips/kernel/ftrace.c:251:15: error: no previous prototype for function 'ftrace_get_parent_ra_addr' [-Werror,-Wmissing-prototypes]
  251 | unsigned long ftrace_get_parent_ra_addr(unsigned long self_ra, unsigned long
      |               ^
arch/mips/kernel/ftrace.c:251:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
  251 | unsigned long ftrace_get_parent_ra_addr(unsigned long self_ra, unsigned long
      | ^
      | static
1 error generated.  

Looks good to me.

Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Note, this should go through the MIPS tree.

-- Steve