Re: [PATCH 14/14] scripts/sorttable: ftrace: Do not add weak functions to available_filter_functions

From
Steven Rostedt <rostedt@goodmis.org>
Date
2025-01-02 19:53:47
Also in
bpf, linux-kbuild, lkml
Reply to
Peter Zijlstra, 2025-01-02
On Thu, 2 Jan 2025 20:48:14 +0100
Peter Zijlstra [off-list ref] wrote:
*sigh*.. can we please just either add the 'hole' symbols in symtab, or
fix symtab to have entry size?

You're just fixing your one problem and leaving everybody else that has
extra data inside the dead weak things up a creek :/

Eg. if might make sense to also ignore alternative / static_branch /
static_call patching for such 'dead' code. Yes, that's not an immediate
problem atm, but just fixing __mcount_loc seems very short sighted.
Read my reply to the email that I forgot to add to the cover letter (but
mention in the last patch). Fixing kallsyms does not remove the place
holders in the available_filter_functions. This has nothing to do with
kallsyms. I need to remove the fentry/mcount references in the mcount_loc
section.

The kallsyms is a completely different issue.

-- Steve
Thread (36 messages) 36 messages, 4 authors, last reply 2025-01-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help