Re: [PATCH v2 06/28] module: Use RCU in find_module_all().
From: Petr Mladek <pmladek@suse.com>
Date: 2025-01-02 14:16:41
Also in:
linux-modules, live-patching, lkml
From: Petr Mladek <pmladek@suse.com>
Date: 2025-01-02 14:16:41
Also in:
linux-modules, live-patching, lkml
On Fri 2024-12-20 18:41:20, Sebastian Andrzej Siewior wrote:
The modules list and module::kallsyms can be accessed under RCU assumption. Remove module_assert_mutex_or_preempt() from find_module_all() so it can be used under RCU protection without warnings. Update its callers to use RCU protection instead of preempt_disable(). Cc: Jiri Kosina <jikos@kernel.org> Cc: Joe Lawrence <joe.lawrence@redhat.com> Cc: Josh Poimboeuf <jpoimboe@kernel.org> Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Cc: Miroslav Benes <mbenes@suse.cz> Cc: Petr Mladek <pmladek@suse.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: linux-trace-kernel@vger.kernel.org Cc: live-patching@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- include/linux/module.h | 2 +- kernel/livepatch/core.c | 4 +--- kernel/module/kallsyms.c | 1 + kernel/module/main.c | 6 ++---- kernel/trace/trace_kprobe.c | 9 +++------ 5 files changed, 8 insertions(+), 14 deletions(-)
I looked primary on the changes in the livepatch code. But the entire patch looks good to me: Reviewed-by: Petr Mladek <pmladek@suse.com> Best Regards, Petr