Re: [PATCH AUTOSEL 6.12 1/5] uprobes: sanitiize xol_free_insn_slot()
From: Oleg Nesterov <oleg@redhat.com>
Date: 2024-11-24 14:37:19
Also in:
linux-perf-users, lkml, stable
From: Oleg Nesterov <oleg@redhat.com>
Date: 2024-11-24 14:37:19
Also in:
linux-perf-users, lkml, stable
On 11/24, Sasha Levin wrote:
On Sun, Nov 24, 2024 at 02:13:57PM +0100, Oleg Nesterov wrote:quoted
Hi Sasha, but why do you think it makes sense to backport these "uprobes" cleanups?If it doesn't, I'm happy to drop them. This commit was selected mostly because of:
I'd suggest to drop.
quoted
quoted
1. Clear utask->xol_vaddr unconditionally, even if this addr is not valid, xol_free_insn_slot() should never return with utask->xol_vaddr != NULL.Which sounded to me like more than a cleanup.
Sorry for confusion. This patch doesn't make much sense without the next changes. Oleg.