Thread (9 messages) 9 messages, 2 authors, 2024-10-11

Re: [PATCH RESEND v3 3/6] rtla/utils: Add idle state disabling via libcpupower

From: Tomas Glozar <tglozar@redhat.com>
Date: 2024-10-11 10:46:27
Also in: lkml

čt 10. 10. 2024 v 22:06 odesílatel Steven Rostedt [off-list ref] napsal:
If nr_states is zero, this returns 0 without ever allocating
saved_cpu_idle_disable_state.
quoted
...
This returns -1 even if nr_states is zero. That is,
save_cpu_idle_disable_state() can return success, but this restore will
return failure.

-- Steve
Oh I see: there might be no idle states to save,
saved_cpu_idle_disable_state doesn't get allocated at all, and then
restore_cpu_idle_disable_state behaves as the saves weren't saved
before. Checking for nr_state should fix that; I'll send a v3.

Tomas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help