Re: [PATCHv3 1/7] uprobe: Add support for session consumer
From: Oleg Nesterov <oleg@redhat.com>
Date: 2024-09-13 10:08:17
Also in:
bpf, lkml
On 09/13, Jiri Olsa wrote:
On Thu, Sep 12, 2024 at 06:20:29PM +0200, Oleg Nesterov wrote:quoted
quoted
+ + if (rc == 0 && uc->ret_handler) {should we enter this block if uc->handler == NULL?yes, consumer can have just ret_handler defined
Sorry, I meant we do not need to push { cookie, id } into return_instance
if uc->handler == NULL.
And in fact I'd prefer (but won't insist) the new
UPROBE_HANDLER_I_WANT_MY_COOKIE_PLEASE
return code to make this logic more explicit.
Oleg.