Re: [PATCH net-next v24 08/13] net: add support for skbs with unreadable frags
From: Jakub Kicinski <kuba@kernel.org>
Date: 2024-09-03 21:40:15
Also in:
bpf, dri-devel, linux-alpha, linux-arch, linux-doc, linux-kselftest, linux-media, linux-mips, lkml, netdev, sparclinux
On Sat, 31 Aug 2024 00:43:08 +0000 Mina Almasry wrote:
static inline bool tcp_skb_can_collapse_to(const struct sk_buff *skb)
{
- return likely(!TCP_SKB_CB(skb)->eor);
+ return likely(!TCP_SKB_CB(skb)->eor && skb_frags_readable(skb));Do you remember why this is here? Both for Rx and Tx what should matter is whether the "readability" matches, right? We can merge two unreadable messages.