On Tue, 13 Aug 2024 21:13:05 +0000 Mina Almasry wrote:
quoted hunk ↗ jump to hunk
+int dev_get_max_mp_channel(const struct net_device *dev)
+{
+ int i, max = -1;
I presume the bug from yesterday is self evident once reported? :)
quoted hunk ↗ jump to hunk
+ ASSERT_RTNL();
+
+ for (i = 0; i < dev->real_num_rx_queues; i++)
+ if (dev->_rx[i].mp_params.mp_priv)
+ /* The number of queues is the idx plus 1. */
+ max = i + 1;
The +1 is odd. The function as it stands reports min channel count.
Not max_mp_channel, if you ask me. And if you renamed it, you don't
have to use -1 as "not installed".
+ return max;