Re: [PATCH v3 0/2] Fix kallsyms with CONFIG_LTO_CLANG
From: Petr Mladek <pmladek@suse.com>
Date: 2024-08-14 12:09:46
Also in:
live-patching, lkml
From: Petr Mladek <pmladek@suse.com>
Date: 2024-08-14 12:09:46
Also in:
live-patching, lkml
On Wed 2024-08-07 15:05:11, Song Liu wrote:
With CONFIG_LTO_CLANG, the compiler/linker adds .llvm.<hash> suffix to local symbols to avoid duplications. Existing scripts/kallsyms sorts symbols without .llvm.<hash> suffix. However, this causes quite some issues later on. Some users of kallsyms, such as livepatch, have to match symbols exactly. Address this by sorting full symbols at build time, and let kallsyms lookup APIs to match the symbols exactly.
The changes look good from the livepatching POV. For both patches, feel free to use: Acked-by: Petr Mladek <pmladek@suse.com> I made a quick glance over the code changes. They look sane. But I did not check them deep enough to provide a valuable Reviewed-by ;-) Best Regards, Petr