Thread (22 messages) 22 messages, 5 authors, 2024-08-09

Re: [PATCH net-next v17 03/14] netdev: support binding dma-buf to netdevice

From: Markus Elfring <hidden>
Date: 2024-08-06 07:11:26
Also in: bpf, dri-devel, linux-alpha, linux-arch, linux-doc, linux-kselftest, linux-media, linux-mips, lkml, netdev, sparclinux

quoted
quoted
+++ b/include/net/devmem.h
@@ -0,0 +1,115 @@
quoted
+#ifndef _NET_DEVMEM_H
+#define _NET_DEVMEM_H
…

I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier
I was gonna apply this change, but I ack'd existing files and I find
that all of them include leading underscores, including some very
recently added files like net/core/page_pool_priv.h.

I would prefer to stick to existing conventions if that's OK, unless
there is widespread agreement to the contrary.
Under which circumstances would you become interested to reduce development risks
also according to undefined behaviour?
https://wiki.sei.cmu.edu/confluence/display/c/CC.+Undefined+Behavior#CC.UndefinedBehavior-ub_106

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help