Re: [PATCH v2 02/12] uprobes: correct mmap_sem locking assumptions in... | linux-trace-kernel

[PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · Andrii Nakryiko <andrii@kernel.org> · 2024-07-01
[PATCH v2 01/12] uprobes: update outdated comment · Andrii Nakryiko <andrii@kernel.org> · 2024-07-01
Re: [PATCH v2 01/12] uprobes: update outdated comment · Oleg Nesterov <oleg@redhat.com> · 2024-07-03
Re: [PATCH v2 01/12] uprobes: update outdated comment · Andrii Nakryiko <hidden> · 2024-07-03
Re: [PATCH v2 01/12] uprobes: update outdated comment · Andrii Nakryiko <hidden> · 2024-07-03
Re: [PATCH v2 01/12] uprobes: update outdated comment · Oleg Nesterov <oleg@redhat.com> · 2024-07-10
Re: [PATCH v2 01/12] uprobes: update outdated comment · Andrii Nakryiko <hidden> · 2024-07-10
[PATCH v2 02/12] uprobes: correct mmap_sem locking assumptions in uprobe_write_opcode() · Andrii Nakryiko <andrii@kernel.org> · 2024-07-01
Re: [PATCH v2 02/12] uprobes: correct mmap_sem locking assumptions in uprobe_write_opcode() · Oleg Nesterov <oleg@redhat.com> · 2024-07-03
Re: [PATCH v2 02/12] uprobes: correct mmap_sem locking assumptions in uprobe_write_opcode() · Masami Hiramatsu (Google) <mhiramat@kernel.org> · 2024-07-03
Re: [PATCH v2 02/12] uprobes: correct mmap_sem locking assumptions in uprobe_write_opcode() · Andrii Nakryiko <hidden> · 2024-07-03
Re: [PATCH v2 02/12] uprobes: correct mmap_sem locking assumptions in uprobe_write_opcode() · Masami Hiramatsu (Google) <mhiramat@kernel.org> · 2024-07-03
[PATCH v2 03/12] uprobes: simplify error handling for alloc_uprobe() · Andrii Nakryiko <andrii@kernel.org> · 2024-07-01
[PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management · Andrii Nakryiko <andrii@kernel.org> · 2024-07-01
Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management · Peter Zijlstra <peterz@infradead.org> · 2024-07-02
Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management · Andrii Nakryiko <hidden> · 2024-07-02
Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management · Peter Zijlstra <peterz@infradead.org> · 2024-07-03
Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management · Andrii Nakryiko <hidden> · 2024-07-03
Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management · Peter Zijlstra <peterz@infradead.org> · 2024-07-04
Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management · Peter Zijlstra <peterz@infradead.org> · 2024-07-04
Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management · Masami Hiramatsu (Google) <mhiramat@kernel.org> · 2024-07-04
Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management · Peter Zijlstra <peterz@infradead.org> · 2024-07-04
Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management · Oleg Nesterov <oleg@redhat.com> · 2024-07-05
Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management · Jiri Olsa <hidden> · 2024-07-06
Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management · Jiri Olsa <hidden> · 2024-07-06
Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management · Oleg Nesterov <oleg@redhat.com> · 2024-07-07
Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management · Andrii Nakryiko <hidden> · 2024-07-08
Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management · Oleg Nesterov <oleg@redhat.com> · 2024-07-09
Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management · Andrii Nakryiko <hidden> · 2024-07-09
Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management · Oleg Nesterov <oleg@redhat.com> · 2024-07-09
Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management · Andrii Nakryiko <hidden> · 2024-07-09
Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management · Andrii Nakryiko <hidden> · 2024-07-08
[PATCH v2 05/12] uprobes: move offset and ref_ctr_offset into uprobe_consumer · Andrii Nakryiko <andrii@kernel.org> · 2024-07-01
Re: [PATCH v2 05/12] uprobes: move offset and ref_ctr_offset into uprobe_consumer · Peter Zijlstra <peterz@infradead.org> · 2024-07-03
Re: [PATCH v2 05/12] uprobes: move offset and ref_ctr_offset into uprobe_consumer · Masami Hiramatsu <hidden> · 2024-07-03
Re: [PATCH v2 05/12] uprobes: move offset and ref_ctr_offset into uprobe_consumer · Andrii Nakryiko <hidden> · 2024-07-03
Re: [PATCH v2 05/12] uprobes: move offset and ref_ctr_offset into uprobe_consumer · Oleg Nesterov <oleg@redhat.com> · 2024-07-07
Re: [PATCH v2 05/12] uprobes: move offset and ref_ctr_offset into uprobe_consumer · Andrii Nakryiko <hidden> · 2024-07-08
[PATCH v2 06/12] uprobes: add batch uprobe register/unregister APIs · Andrii Nakryiko <andrii@kernel.org> · 2024-07-01
[PATCH v2 07/12] uprobes: inline alloc_uprobe() logic into __uprobe_register() · Andrii Nakryiko <andrii@kernel.org> · 2024-07-01
[PATCH v2 08/12] uprobes: split uprobe allocation and uprobes_tree insertion steps · Andrii Nakryiko <andrii@kernel.org> · 2024-07-01
[PATCH v2 09/12] uprobes: batch uprobes_treelock during registration · Andrii Nakryiko <andrii@kernel.org> · 2024-07-01
[PATCH v2 10/12] uprobes: improve lock batching for uprobe_unregister_batch · Andrii Nakryiko <andrii@kernel.org> · 2024-07-01
[PATCH v2 11/12] uprobes,bpf: switch to batch uprobe APIs for BPF multi-uprobes · Andrii Nakryiko <andrii@kernel.org> · 2024-07-01
[PATCH v2 12/12] uprobes: switch uprobes_treelock to per-CPU RW semaphore · Andrii Nakryiko <andrii@kernel.org> · 2024-07-01
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · Peter Zijlstra <peterz@infradead.org> · 2024-07-02
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · Peter Zijlstra <peterz@infradead.org> · 2024-07-02
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · Peter Zijlstra <peterz@infradead.org> · 2024-07-02
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · Andrii Nakryiko <hidden> · 2024-07-02
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · Peter Zijlstra <peterz@infradead.org> · 2024-07-02
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · "Paul E. McKenney" <paulmck@kernel.org> · 2024-07-02
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · Andrii Nakryiko <hidden> · 2024-07-03
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · Peter Zijlstra <peterz@infradead.org> · 2024-07-03
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · "Paul E. McKenney" <paulmck@kernel.org> · 2024-07-03
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · Peter Zijlstra <peterz@infradead.org> · 2024-07-04
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · "Paul E. McKenney" <paulmck@kernel.org> · 2024-07-04
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · Steven Rostedt <rostedt@goodmis.org> · 2024-07-03
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · "Paul E. McKenney" <paulmck@kernel.org> · 2024-07-03
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · Andrii Nakryiko <hidden> · 2024-07-03
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · Peter Zijlstra <peterz@infradead.org> · 2024-07-03
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · Andrii Nakryiko <hidden> · 2024-07-03
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · Andrii Nakryiko <hidden> · 2024-07-03
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · Peter Zijlstra <peterz@infradead.org> · 2024-07-04
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · Steven Rostedt <rostedt@goodmis.org> · 2024-07-04
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · "Paul E. McKenney" <paulmck@kernel.org> · 2024-07-04
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · Andrii Nakryiko <hidden> · 2024-07-08
Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore · Andrii Nakryiko <hidden> · 2024-07-08

Re: [PATCH v2 02/12] uprobes: correct mmap_sem locking assumptions in uprobe_write_opcode()

From: Oleg Nesterov <oleg@redhat.com>
Date: 2024-07-03 11:42:51
Also in: bpf

On 07/01, Andrii Nakryiko wrote:

quoted hunk ↗ jump to hunk

--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c

@@ -453,7 +453,7 @@ static int update_ref_ctr(struct uprobe *uprobe, struct mm_struct *mm,
  * @vaddr: the virtual address to store the opcode.
  * @opcode: opcode to be written at @vaddr.
  *
- * Called with mm->mmap_lock held for write.
+ * Called with mm->mmap_lock held for read or write.
  * Return 0 (success) or a negative errno.

Thanks,

Acked-by: Oleg Nesterov <oleg@redhat.com>


I'll try to send the patch which explains the reasons for mmap_write_lock()
in register_for_each_vma() later.

Oleg.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help