Thread (29 messages) flat view 29 messages, 6 authors, 2024-07-03

Re: [PATCH 01/10] fs: turn inode ctime fields into a single ktime_t

From: Jeff Layton <jlayton@kernel.org>
Date: 2024-07-02 09:56:40
Also in: linux-btrfs, linux-ext4, linux-fsdevel, linux-mm, linux-nfs, linux-xfs, lkml

On Tue, 2024-07-02 at 00:37 -0700, Christoph Hellwig wrote:
On Mon, Jul 01, 2024 at 08:22:07PM -0400, Jeff Layton wrote:
quoted
2) the filesystem has been altered (fuzzing? deliberate doctoring?).

None of these seem like legitimate use cases so I'm arguing that we
shouldn't worry about them.
Not worry seems like the wrong answer here.  Either we decide they
are legitimate enough and we preserve them, or we decide they are
bogus and refuse reading the inode.  But we'll need to consciously
deal with the case.
Is there a problem with consciously dealing with it by clamping the
time at KTIME_MAX? If I had a fs with corrupt timestamps, the last
thing I'd want is the filesystem refusing to let me at my data because
of them.
-- 
Jeff Layton [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help