Re: tracing: user events UAF crash report
From: Mathias Krause <hidden>
Date: 2024-07-25 19:53:08
Also in:
lkml
On 25.07.24 21:05, Steven Rostedt wrote:
quoted hunk ↗ jump to hunk
Here's the proper fix:diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 6ef29eba90ce..3a2d2ff1625b 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c@@ -3140,8 +3140,10 @@ EXPORT_SYMBOL_GPL(trace_add_event_call); */ static void __trace_remove_event_call(struct trace_event_call *call) { + lockdep_assert_held(&event_mutex); event_remove(call); trace_destroy_fields(call); + call->get_fields = NULL;
That should be: + call->class->get_fields = NULL;
free_event_filter(call->filter); call->filter = NULL; } Can you try it out?
Just tried, dies the same way, as expected. Thanks, Mathias