Thread (45 messages) 45 messages, 5 authors, 2024-07-27

Re: [PATCH v2 10/11] perf/uprobe: Convert single-step and uretprobe to SRCU

From: Oleg Nesterov <oleg@redhat.com>
Date: 2024-07-12 10:28:18
Also in: lkml

On 07/11, Peter Zijlstra wrote:
  uprobe_free_stage1
    call_srcu(&uretprobe_srcu, &uprobe->rcu, uprobe_free_stage2);

  put_uprobe()
    if (refcount_dec_and_test)
      call_srcu(&uprobes_srcu, &uprobe->rcu, uprobe_free_stage1);


So my thinking was since we take uretprobe_srcu *inside* uprobe_srcu,
Ah, indeed! Somehow misread the change in put_uprobe() as if it
uses call_rcu(uretprobe_srcu).

Thanks,

Oleg.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help