Thread (10 messages) flat view 10 messages, 5 authors, 2024-07-02

Re: [PATCH 0/14] New uid & gid mount option parsing helpers

From: Christian Brauner <brauner@kernel.org>
Date: 2024-06-28 11:51:35
Also in: autofs, linux-cifs, linux-efi, linux-ext4, linux-fsdevel, linux-mm, ntfs3

On Thu, Jun 27, 2024 at 07:24:59PM GMT, Eric Sandeen wrote:
Multiple filesystems take uid and gid as options, and the code to
create the ID from an integer and validate it is standard boilerplate
that can be moved into common helper functions, so do that for
consistency and less cut&paste.

This also helps avoid the buggy pattern noted by Seth Jenkins at
https://lore.kernel.org/lkml/CALxfFW4BXhEwxR0Q5LSkg-8Vb4r2MONKCcUCVioehXQKr35eHg@mail.gmail.com/ (local)
because uid/gid parsing will fail before any assignment in most
filesystems.

Net effect is a bit of code removal, as well.
Thanks, this all looks good to me. I'll have one comment about the fuse
patch.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help