Re: [PATCH] vfs: Add AT_EMPTY_PATH_NOCHECK as unchecked AT_EMPTY_PATH
From: Xi Ruoyao <xry111@xry111.site>
Date: 2024-06-23 00:59:55
Also in:
linux-arch, linux-fsdevel, lkml, loongarch
From: Xi Ruoyao <xry111@xry111.site>
Date: 2024-06-23 00:59:55
Also in:
linux-arch, linux-fsdevel, lkml, loongarch
On Sat, 2024-06-22 at 15:41 -0700, Linus Torvalds wrote:
I do think that we should make AT_EMPTY_PATH with a NULL path "JustWork(tm)", because the stupid "look if the pathname is empty" is horrible. But moving that check into getname() is *NOT* the right answer, because by the time you get to getname(), you have already lost.
Oops. I'll try to get around of getname() too...
So the short-cut in vfs_fstatat() to never get a pathname is disgusting - people should have used 'fstat()' - but it's _important_ disgusting.
The problem is we don't have fstat() for LoongArch, and it'll be unusable on all 32-bit arch after 2037. And Arnd hates the idea adding fstat() for LoongArch because there would be one more 32-bit arch broken in 2037. Or should we just add something like "fstat_2037()"? -- Xi Ruoyao [off-list ref] School of Aerospace Science and Technology, Xidian University