Thread (21 messages) 21 messages, 7 authors, 2024-07-01

Re: [PATCH] LoongArch: uprobes: make UPROBE_SWBP_INSN/UPROBE_XOLBP_INSN constant

From: Tiezhu Yang <yangtiezhu@loongson.cn>
Date: 2024-06-29 12:48:08
Also in: bpf, lkml, loongarch

On Thu, 27 Jun 2024 19:38:06 +0200
Oleg Nesterov [off-list ref] wrote:

...

 > > > +arch_initcall(check_emit_break);
 > > > +
 > >
 > > I wouldn't even bother with this, but whatever.
 >
 > Agreed, this looks a bit ugly. I did this only because I can not test
 > this (hopefully trivial) patch and the maintainers didn't reply.

The LoongArch maintainer Huacai told me offline to reply this thread today.

 > If LoongArch boots at least once with this change, this run-time check
 > can be removed.

I will test it next Monday.

 > And just in case... I didn't dare to make a more "generic" change, but
 > perhaps KPROBE_BP_INSN and KPROBE_SSTEPBP_INSN should be redefined the
 > same way for micro-optimization. In this case __emit_break() should be
 > probably moved into arch/loongarch/include/asm/inst.h.

Yeah. I think so too.

Thanks,
Tiezhu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help