Thread (21 messages) 21 messages, 5 authors, 2024-07-10

Re: [PATCH v2 4/4] EDAC/mce_amd: Add support for FRU Text in MCA

From: Borislav Petkov <bp@alien8.de>
Date: 2024-06-26 18:20:38
Also in: linux-acpi, linux-edac, lkml

On Wed, Jun 26, 2024 at 01:00:30PM -0500, Naik, Avadhut wrote:
quoted
Why are you clearing it if you're overwriting it immediately?
Since its a local variable, wanted to ensure that the memory is zeroed out to prevent
any issues with the %s specifier, used later on.
What issues?
Would you recommend removing that and using initializer instead for the string?
I'd recommend looking at what the code does and then really thinking whether
that makes any sense.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help