Thread (16 messages) 16 messages, 3 authors, 2024-06-19

Re: [PATCH net-next v5 1/7] net: add rx_sk to trace_kfree_skb

From: Jesper Dangaard Brouer <hawk@kernel.org>
Date: 2024-06-18 06:15:52
Also in: lkml, netdev


On 17/06/2024 20.09, Yan Zhai wrote:
skb does not include enough information to find out receiving
sockets/services and netns/containers on packet drops. In theory
skb->dev tells about netns, but it can get cleared/reused, e.g. by TCP
stack for OOO packet lookup. Similarly, skb->sk often identifies a local
sender, and tells nothing about a receiver.

Allow passing an extra receiving socket to the tracepoint to improve
the visibility on receiving drops.

Signed-off-by: Yan Zhai<redacted>
---
v4->v5: rename rx_skaddr -> rx_sk as Jesper Dangaard Brouer suggested
v3->v4: adjusted the TP_STRUCT field order to be consistent
v2->v3: fixed drop_monitor function prototype
---
  include/trace/events/skb.h | 11 +++++++----
  net/core/dev.c             |  2 +-
  net/core/drop_monitor.c    |  9 ++++++---
  net/core/skbuff.c          |  2 +-
  4 files changed, 15 insertions(+), 9 deletions(-)
Acked-by: Jesper Dangaard Brouer <hawk@kernel.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help