On Mon, 27 May 2024 09:09:49 +0900
Masami Hiramatsu (Google) [off-list ref] wrote:
quoted
Note, we do not care about races. If a bit is set before the gops is
assigned, it only wastes time looking at the element and ignoring it (as
it did before this bitmask is added).
This is OK because anyway we check gops == &fgraph_stub.
By the way, shouldn't we also make "if (gops == &fgraph_stub)"
check unlikely()?
Yeah, I'll add the unlikely() here too.
This change looks good to me.
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thanks for the review Masami!
-- Steve