Re: [PATCH 20/20] function_graph: Use bitmask to loop on fgraph entry

From
Steven Rostedt <rostedt@goodmis.org>
Date
2024-05-27 00:32:28
Also in
bpf, lkml
Reply to
Masami Hiramatsu (Google), 2024-05-27
On Mon, 27 May 2024 09:09:49 +0900
Masami Hiramatsu (Google) [off-list ref] wrote:
quoted
Note, we do not care about races. If a bit is set before the gops is
assigned, it only wastes time looking at the element and ignoring it (as
it did before this bitmask is added).  
This is OK because anyway we check gops == &fgraph_stub.
By the way, shouldn't we also make "if (gops == &fgraph_stub)"
check unlikely()?
Yeah, I'll add the unlikely() here too.
This change looks good to me.

Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thanks for the review Masami!

-- Steve
Thread (37 messages) 37 messages, 2 authors, last reply 2024-06-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help