[PATCH v2 0/4] tracefs/eventfs: Fix failed second run of test_ownership
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2024-05-23 05:14:55
Also in:
lkml
The test_ownership test of the kselftests was failing again. That's because the original fix was incorrect and a fix to a race condition showed how the original fix was broken. Instead of using tracefs_inodes to find the eventfs_inode that needs to be reset on remount, use the "events" directory descriptor to descend into its files and directories to catch all changes. Changes since v1: https://lore.kernel.org/linux-trace-kernel/20240522124504.28982867@gandalf.local.home (local) - Added other fixes underneath and rebased it on: https://lore.kernel.org/lkml/20240522164320.469785149@goodmis.org/ (local) - The real fix is to not use the tracefs_inodes to find the eventfs_inodes that need to be cleared on remount. Instead, the events descriptor needs to be used to descend its directories and files to update their attributes - The d_iput callback logic was misplaced. It should be done in the drop_inode callback. git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git eventfs/urgent Head SHA1: 41b7db11bcac4638fa489c58d35e7d2146b665ab Steven Rostedt (Google) (4): eventfs: Keep the directories from having the same inode number as files tracefs: Update inode permissions on remount eventfs: Update all the eventfs_inodes from the events descriptor tracefs: Clear EVENT_INODE flag in tracefs_drop_inode() ---- fs/tracefs/event_inode.c | 57 +++++++++++++++++++++++++++++++++++++----------- fs/tracefs/inode.c | 48 ++++++++++++++++++++++++---------------- 2 files changed, 73 insertions(+), 32 deletions(-)