On Wed, 1 May 2024 17:45:49 +0300
Mike Rapoport [off-list ref] wrote:
quoted
+static void __init memmap_copy(void)
+{
+ if (!early_mmap_size)
+ return;
+
+ mmap_list = kcalloc(early_mmap_size + 1, sizeof(mmap_list), GFP_KERNEL);
We can keep early_mmap_size after boot and then we don't need to allocate
an extra element in the mmap_list. No strong feeling here, though.
quoted
+ if (!mmap_list)
+ return;
+
+ for (int i = 0; i < early_mmap_size; i++)
+ mmap_list[i] = early_mmap_list[i];
+}
With something like this
/*
* Parse early_reserve_mem=nn:align:name
*/
static int __init early_reserve_mem(char *p)
{
phys_addr_t start, size, align;
char *oldp;
int err;
if (!p)
return -EINVAL;
oldp = p;
size = memparse(p, &p);
if (p == oldp)
return -EINVAL;
if (*p != ':')
return -EINVAL;
align = memparse(p+1, &p);
if (*p != ':')
return -EINVAL;
start = memblock_phys_alloc(size, align);
So this will allocate the same physical location for every boot, if booting
the same kernel and having the same physical memory layout?
-- Steve
if (!start)
return -ENOMEM;
p++;
err = memmap_add(start, size, p);
if (err) {
memblock_phys_free(start, size);
return err;
}
p += strlen(p);
return *p == '\0' ? 0: -EINVAL;
}
__setup("early_reserve_mem=", early_reserve_mem);
you don't need to touch e820 and it will work the same for all
architectures.
We'd need a better naming, but I couldn't think of something better yet.
quoted
+
+/**
+ * memmap_named - Find a wildcard region with a given name
+ * @name: The name that is attached to a wildcard region
+ * @start: If found, holds the start address
+ * @size: If found, holds the size of the address.
+ *
+ * Returns: 1 if found or 0 if not found.
+ */
+int memmap_named(const char *name, u64 *start, u64 *size)
+{
+ struct mmap_map *map;
+
+ if (!mmap_list)
+ return 0;
+
+ for (int i = 0; mmap_list[i].name[0]; i++) {
+ map = &mmap_list[i];
+ if (!map->size)
+ continue;
+ if (strcmp(name, map->name) == 0) {
+ *start = map->start;
+ *size = map->size;
+ return 1;
+ }
+ }
+ return 0;
+}
+
struct kobject *mm_kobj;
#ifdef CONFIG_SMP@@ -2793,4 +2864,5 @@ void __init mm_core_init(void)
pti_init();
kmsan_init_runtime();
mm_cache_init();
+ memmap_copy();
}