Re: [PATCH v7 10/36] ftrace/function_graph: Pass fgraph_ops to function graph callbacks
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Date: 2024-02-14 13:28:12
Also in:
bpf, lkml
On Tue, 13 Feb 2024 20:42:18 -0500 Steven Rostedt [off-list ref] wrote:
On Wed, 7 Feb 2024 00:09:21 +0900 "Masami Hiramatsu (Google)" [off-list ref] wrote:quoted
From: Steven Rostedt (VMware) <rostedt@goodmis.org> Pass the fgraph_ops structure to the function graph callbacks. This will allow callbacks to add a descriptor to a fgraph_ops private field that wil be added in the future and use it for the callbacks. This will be useful when more than one callback can be registered to the function graph tracer. Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> --- Changes in v2: - cleanup to set argument name on function prototype. ---This patch fails to compile without this change:
Thanks for pointing it out! Let me fix this in next version.
quoted hunk ↗ jump to hunk
diff --git a/kernel/trace/fgraph.c b/kernel/trace/fgraph.c index e35a941a5af3..47b461b1cf7e 100644 --- a/kernel/trace/fgraph.c +++ b/kernel/trace/fgraph.c@@ -381,7 +381,7 @@ int function_graph_enter(unsigned long ret, unsigned long func, if (gops == &fgraph_stub) continue; - if (gops->entryfunc(&trace)) + if (gops->entryfunc(&trace, gops)) bitmap |= BIT(i); } -- Steve
-- Masami Hiramatsu (Google) [off-list ref]