Re: [PATCH v5 5/8] tracing: add new type "%pd/%pD" in readme_msg[]
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Date: 2024-02-07 14:33:01
Also in:
lkml
On Thu, 25 Jan 2024 15:39:20 +0800 Ye Bin [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Ye Bin <redacted> --- kernel/trace/trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 2a7c6fd934e9..13197d3b86bd 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c@@ -5745,7 +5745,7 @@ static const char readme_msg[] = "\t +|-[u]<offset>(<fetcharg>), \\imm-value, \\\"imm-string\"\n" "\t type: s8/16/32/64, u8/16/32/64, x8/16/32/64, char, string, symbol,\n" "\t b<bit-width>@<bit-offset>/<container-size>, ustring,\n" - "\t symstr, <type>\\[<array-size>\\]\n" + "\t symstr, %pd/%pD <type>\\[<array-size>\\]\n"
Almost! you missed the ',' after %pd/%pD. :) Thank you,
#ifdef CONFIG_HIST_TRIGGERS "\t field: <stype> <name>;\n" "\t stype: u8/u16/u32/u64, s8/s16/s32/s64, pid_t,\n" -- 2.31.1
-- Masami Hiramatsu (Google) [off-list ref]