Thread (43 messages) 43 messages, 4 authors, 2024-01-31

Re: [PATCH 5/6] eventfs: get rid of dentry pointers without refcounts

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2024-01-30 23:04:27
Also in: lkml

On Tue, 30 Jan 2024 14:58:26 -0800
Linus Torvalds [off-list ref] wrote:
On Tue, 30 Jan 2024 at 14:55, Steven Rostedt [off-list ref] wrote:
quoted
Remember, the files don't have an ei allocated. Only directories.  
Crossed emails.
quoted
I then counted the length of the string - 7 bytes (which is the same as the
length of the string plus the '\0' character - 8 bytes) to accommodate the
pointer size, and it's a savings of 22KB per instance. And in actuality, I
should have rounded to the nearest kmalloc slab size as kzalloc() isn't going to
return 35 bytes back but 64 bytes will be allocated.  
No. See my other email. The kmalloc sizes actually means that it comes
out exactly even.
But that wouldn't be the case if I switched over to allocating as its own
slab, as it would make it better condensed.

But, I can keep it your way until I do that, as the biggest savings I
needed was getting rid of all the file meta-data as that was what took up
10s of megabytes.

-- Steve
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help