On Sat, Sep 30, 2023 at 06:19:02PM +0900, Masami Hiramatsu wrote:
On Fri, 29 Sep 2023 13:37:08 +0200 (CEST)
Julia Lawall [off-list ref] wrote:
quoted
On Fri, 29 Sep 2023, Masami Hiramatsu wrote:
quoted
On Thu, 28 Sep 2023 12:43:34 +0200
Julia Lawall [off-list ref] wrote:
quoted
Drop break after return.
Good catch! This looks good to me.
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
And
Fixes: 7491e2c44278 ("tracing: Add a probe that attaches to trace events")
Thanks. I didn't include that because it's not a bug. But it does break
Coccinelle, which is how I noticed it.
OK, I got it. I thought it may cause a compiler warning because the
'break' never be executed. (maybe it is just a flow-control word,
so it may not need to be warned, but a bit storange.)
I don't think GCC warns about unreachable code, but yeah, in Smatch
unreachable break statements do not trigger a warning. People like
to add extra break statements to switch statements.
regards,
dan carpenter