Re: [PATCH v1 1/1] bitops: Share BYTES_TO_BITS() for everyone
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2023-08-31 13:21:38
Also in:
lkml
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2023-08-31 13:21:38
Also in:
lkml
On Fri, Aug 25, 2023 at 04:49:07PM +0200, Alexander Lobakin wrote:
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Date: Thu, 24 Aug 2023 15:37:28 +0300quoted
It may be new callers for the same macro, share it. Note, it's unknown why it's represented in the current form instead of simple multiplication and commit 1ff511e35ed8 ("tracing/kprobes: Add bitfield type") doesn't explain that neither. Let leave it as is and we may improve it in the future.Maybe symmetrical change in tools/ like I did[0] an aeon ago?
Hmm... Why can't you simply upstream your version? It seems better than mine.
[0] https://github.com/alobakin/linux/commit/fd308001fe6d38837fe820427209a6a99e4850a8
-- With Best Regards, Andy Shevchenko