[PATCH] visl: use canonical ftrace path

From: Ross Zwisler <redacted>

The canonical location for the tracefs filesystem is at /sys/kernel/tracing.

But, from Documentation/trace/ftrace.rst:

  Before 4.1, all ftrace tracing control files were within the debugfs
  file system, which is typically located at /sys/kernel/debug/tracing.
  For backward compatibility, when mounting the debugfs file system,
  the tracefs file system will be automatically mounted at:

  /sys/kernel/debug/tracing

Update the visl decoder driver documentation to use this tracefs path.

Signed-off-by: Ross Zwisler <redacted>
---
 Documentation/admin-guide/media/visl.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/admin-guide/media/visl.rst b/Documentation/admin-guide/media/visl.rst
index 7d2dc78341c9..4328c6c72d30 100644
--- a/Documentation/admin-guide/media/visl.rst
+++ b/Documentation/admin-guide/media/visl.rst

@@ -78,7 +78,7 @@ The trace events are defined on a per-codec basis, e.g.:
 
 .. code-block:: bash
 
-        $ ls /sys/kernel/debug/tracing/events/ | grep visl
+        $ ls /sys/kernel/tracing/events/ | grep visl
         visl_fwht_controls
         visl_h264_controls
         visl_hevc_controls

@@ -90,13 +90,13 @@ For example, in order to dump HEVC SPS data:
 
 .. code-block:: bash
 
-        $ echo 1 >  /sys/kernel/debug/tracing/events/visl_hevc_controls/v4l2_ctrl_hevc_sps/enable
+        $ echo 1 >  /sys/kernel/tracing/events/visl_hevc_controls/v4l2_ctrl_hevc_sps/enable
 
 The SPS data will be dumped to the trace buffer, i.e.:
 
 .. code-block:: bash
 
-        $ cat /sys/kernel/debug/tracing/trace
+        $ cat /sys/kernel/tracing/trace
         video_parameter_set_id 0
         seq_parameter_set_id 0
         pic_width_in_luma_samples 1920

-- 
2.42.0.rc2.253.gd59a3bf2b4-goog

On Tue, 29 Aug 2023 14:46:01 -0600
Ross Zwisler [off-list ref] wrote:

From: Ross Zwisler <redacted>

The canonical location for the tracefs filesystem is at /sys/kernel/tracing.

But, from Documentation/trace/ftrace.rst:

  Before 4.1, all ftrace tracing control files were within the debugfs
  file system, which is typically located at /sys/kernel/debug/tracing.
  For backward compatibility, when mounting the debugfs file system,
  the tracefs file system will be automatically mounted at:

  /sys/kernel/debug/tracing

Update the visl decoder driver documentation to use this tracefs path.

Signed-off-by: Ross Zwisler <redacted>

Looks good to me.

Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Thanks!

-- 
Masami Hiramatsu (Google) [off-list ref]

On Tue, 29 Aug 2023 14:46:01 -0600
Ross Zwisler [off-list ref] wrote:

From: Ross Zwisler <redacted>

The canonical location for the tracefs filesystem is at /sys/kernel/tracing.

But, from Documentation/trace/ftrace.rst:

  Before 4.1, all ftrace tracing control files were within the debugfs
  file system, which is typically located at /sys/kernel/debug/tracing.
  For backward compatibility, when mounting the debugfs file system,
  the tracefs file system will be automatically mounted at:

  /sys/kernel/debug/tracing

Update the visl decoder driver documentation to use this tracefs path.

Signed-off-by: Ross Zwisler <redacted>

Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>

Thanks Ross!

-- Steve

Could this go through the linux-media tree, or if you give it an Ack, I'll
take it through the tracing tree.

-- Steve


On Tue, 29 Aug 2023 14:46:01 -0600
Ross Zwisler [off-list ref] wrote:

On 03/10/2023 23:41, Steven Rostedt wrote:

Could this go through the linux-media tree, or if you give it an Ack, I'll
take it through the tracing tree.

I prefer to take this through the media subsystem. Ross, can you post this
patch again, this time including linux-media@vger.kernel.org?

The patch looks fine, so I'll pick it up.

Regards,

	Hans

-- Steve


On Tue, 29 Aug 2023 14:46:01 -0600
Ross Zwisler [off-list ref] wrote:

quoted

From: Ross Zwisler <redacted>

The canonical location for the tracefs filesystem is at /sys/kernel/tracing.

But, from Documentation/trace/ftrace.rst:

  Before 4.1, all ftrace tracing control files were within the debugfs
  file system, which is typically located at /sys/kernel/debug/tracing.
  For backward compatibility, when mounting the debugfs file system,
  the tracefs file system will be automatically mounted at:

  /sys/kernel/debug/tracing

Update the visl decoder driver documentation to use this tracefs path.

Signed-off-by: Ross Zwisler <redacted>
---
 Documentation/admin-guide/media/visl.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/admin-guide/media/visl.rst b/Documentation/admin-guide/media/visl.rst
index 7d2dc78341c9..4328c6c72d30 100644
--- a/Documentation/admin-guide/media/visl.rst
+++ b/Documentation/admin-guide/media/visl.rst

@@ -78,7 +78,7 @@ The trace events are defined on a per-codec basis, e.g.:
 
 .. code-block:: bash
 
-        $ ls /sys/kernel/debug/tracing/events/ | grep visl
+        $ ls /sys/kernel/tracing/events/ | grep visl
         visl_fwht_controls
         visl_h264_controls
         visl_hevc_controls

@@ -90,13 +90,13 @@ For example, in order to dump HEVC SPS data:
 
 .. code-block:: bash
 
-        $ echo 1 >  /sys/kernel/debug/tracing/events/visl_hevc_controls/v4l2_ctrl_hevc_sps/enable
+        $ echo 1 >  /sys/kernel/tracing/events/visl_hevc_controls/v4l2_ctrl_hevc_sps/enable
 
 The SPS data will be dumped to the trace buffer, i.e.:
 
 .. code-block:: bash
 
-        $ cat /sys/kernel/debug/tracing/trace
+        $ cat /sys/kernel/tracing/trace
         video_parameter_set_id 0
         seq_parameter_set_id 0
         pic_width_in_luma_samples 1920

On Wed, 4 Oct 2023 08:33:12 +0200
Hans Verkuil [off-list ref] wrote:

On 03/10/2023 23:41, Steven Rostedt wrote:

quoted

Could this go through the linux-media tree, or if you give it an Ack, I'll
take it through the tracing tree.  

I prefer to take this through the media subsystem. Ross, can you post this

Thanks!

patch again, this time including linux-media@vger.kernel.org?

The original patch did have linux-media@vger.kernel.org Cc'd. Was it dropped?

-- Steve

The patch looks fine, so I'll pick it up.

Regards,

	Hans

On 10/4/23 15:57, Steven Rostedt wrote:

On Wed, 4 Oct 2023 08:33:12 +0200
Hans Verkuil [off-list ref] wrote:

quoted

On 03/10/2023 23:41, Steven Rostedt wrote:

quoted

Could this go through the linux-media tree, or if you give it an Ack, I'll
take it through the tracing tree.  

I prefer to take this through the media subsystem. Ross, can you post this

Thanks!

quoted

patch again, this time including linux-media@vger.kernel.org?

The original patch did have linux-media@vger.kernel.org Cc'd. Was it dropped?

You are correct, it was sitting in patchwork, I somehow missed it.

It's now delegated to me, so it is in my pipeline.

Regards,

	Hans

-- Steve

quoted

The patch looks fine, so I'll pick it up.

Regards,

	Hans

On Wed, 4 Oct 2023 16:00:34 +0200
Hans Verkuil [off-list ref] wrote:

quoted

The original patch did have linux-media@vger.kernel.org Cc'd. Was it dropped?  

You are correct, it was sitting in patchwork, I somehow missed it.

It's now delegated to me, so it is in my pipeline.

Thanks a lot! I appreciate it.

-- Steve