Thread (30 messages) 30 messages, 4 authors, 2023-08-21

Re: [PATCH v2] tracing: Introduce pipe_cpumask to avoid race on trace_pipes

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2023-08-18 15:54:15
Also in: lkml

On Fri, 18 Aug 2023 23:23:01 +0900
Masami Hiramatsu (Google) [off-list ref] wrote:
It uses trace_pipe_raw. I guess if splice(from trace_pipe_raw to virtio-serial)
returns -1 and errno == EAGAIN, the trace data will be lost?
It shouldn't. If it does, then there's likely a bug. The code will block
and if an interrupt comes in it will return immediately without reading
from the buffer.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/kernel/trace/trace.c#n8262

I don't see where it would return -EINTR and consume data, but I may be
missing something.

-- Steve
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help