Re: [PATCH v3] tracepoint: add new `tcp:tcp_ca_event` trace event
From: Joe Perches <joe@perches.com>
Date: 2023-08-13 01:17:27
Also in:
bpf, lkml, netdev
On Sat, 2023-08-12 at 21:04 -0400, Steven Rostedt wrote:
On Sat, 12 Aug 2023 21:01:40 -0400 Steven Rostedt [off-list ref] wrote:quoted
On Sat, 12 Aug 2023 20:59:05 -0400 Steven Rostedt [off-list ref] wrote:quoted
On Sat, 12 Aug 2023 20:12:50 +0000 Zheao Li [off-list ref] wrote:quoted
+TRACE_EVENT(tcp_ca_event, + + TP_PROTO(struct sock *sk, const u8 ca_event), + + TP_ARGS(sk, ca_event), + + TP_STRUCT__entry( + __field(const void *, skaddr) + __field(__u16, sport) + __field(__u16, dport) + __field(__u16, family) + __array(__u8, saddr, 4) + __array(__u8, daddr, 4) + __array(__u8, saddr_v6, 16) + __array(__u8, daddr_v6, 16) + __field(__u8, ca_event)Please DO NOT LISTEN TO CHECKPATCH!I forgot to say "for TRACE_EVENT() macros". This is not about what checkpatch says about other code.
trace has its own code style and checkpatch needs another parsing mechanism just for it, including the alignment to open parenthesis test.