Thread (9 messages) 9 messages, 3 authors, 2023-08-05

Re: [PATCH 1/2] tracing: Fix cpu buffers unavailable due to 'record_disabled' messed

From: Zheng Yejian <hidden>
Date: 2023-08-05 01:58:20
Also in: linux-kselftest, lkml, llvm, oe-kbuild-all

On 2023/8/5 00:51, Steven Rostedt wrote:
On Sat, 5 Aug 2023 00:41:13 +0800
kernel test robot [off-list ref] wrote:
quoted
   5276			if (cpumask_test_cpu(cpu, tr->tracing_cpumask) &&
   5277					!cpumask_test_cpu(cpu, tracing_cpumask_new)) {
   5278				atomic_inc(&per_cpu_ptr(tr->array_buffer.data, cpu)->disabled);
   5279				ring_buffer_record_disable_cpu(tr->array_buffer.buffer, cpu);
quoted
5280				ring_buffer_record_disable_cpu(tr->max_buffer.buffer, cpu);
The access to max_buffer requires a:

#ifdef CONFIG_TRACER_MAX_TRACE

Around them.

-- Steve
Thanks, Steve, I'll add it in v2.

-- Zheng Yejian
quoted
   5281			}
   5282			if (!cpumask_test_cpu(cpu, tr->tracing_cpumask) &&
   5283					cpumask_test_cpu(cpu, tracing_cpumask_new)) {
   5284				atomic_dec(&per_cpu_ptr(tr->array_buffer.data, cpu)->disabled);
   5285				ring_buffer_record_enable_cpu(tr->array_buffer.buffer, cpu);
   5286				ring_buffer_record_enable_cpu(tr->max_buffer.buffer, cpu);
   5287			}
   5288		}
   5289		arch_spin_unlock(&tr->max_lock);
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help