Re: [PATCH v2] selftests/ftrace: traceonoff_triggers: strip off names
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2023-08-17 13:06:38
Also in:
linux-kselftest
On Thu, 17 Aug 2023 09:02:33 -0400 Steven Rostedt [off-list ref] wrote:
Shuah, Can you take this in your tree?
Actually, hold off please.
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org> -- Steve On Thu, 17 Aug 2023 14:16:03 +0900 Masami Hiramatsu (Google) [off-list ref] wrote:quoted
On Thu, 17 Aug 2023 10:50:28 +0800 Yipeng Zou [off-list ref] wrote:
quoted
quoted
Fixes: d87b29179aa0 ("selftests: ftrace: Use md5sum to take less time of checking logs") Suggested-by: Steven Rostedt (Google) <rostedt@goodmis.org> Signed-off-by: Yipeng Zou <redacted> --- .../ftrace/test.d/ftrace/func_traceonoff_triggers.tc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc index aee22289536b..c5783999582d 100644 --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc@@ -90,9 +90,9 @@ if [ $on != "0" ]; then fail "Tracing is not off" fi -csum1=`md5sum trace`
Yipeng, can you please add the comment here: # Cannot rely on names being around as they are only cached, strip them
quoted
quoted
+csum1=`cat trace | sed -e 's/^ *[^ ]*\(-[0-9][0-9]*\)/\1/' | md5sum`
-- Steve
quoted
quoted
sleep $SLEEP_TIME -csum2=`md5sum trace` +csum2=`cat trace | sed -e 's/^ *[^ ]*\(-[0-9][0-9]*\)/\1/' | md5sum` if [ "$csum1" != "$csum2" ]; then fail "Tracing file is still changing" -- 2.34.1