Thread (13 messages) 13 messages, 3 authors, 2023-07-26

Re: [RFC PATCH 1/3] sched, tracing: report task state in symbolic chars instead

From: Peter Zijlstra <peterz@infradead.org>
Date: 2023-07-25 13:32:17
Also in: linux-perf-users, lkml

On Tue, Jul 25, 2023 at 06:53:07PM +0800, Ze Gao wrote:
quoted
quoted
@@ -232,7 +235,7 @@ TRACE_EVENT(sched_switch,
              __array(        char,   prev_comm,      TASK_COMM_LEN   )
              __field(        pid_t,  prev_pid                        )
              __field(        int,    prev_prio                       )
-             __field(        long,   prev_state                      )
+             __field(        char,   prev_state                      )
              __array(        char,   next_comm,      TASK_COMM_LEN   )
              __field(        pid_t,  next_pid                        )
              __field(        int,    next_prio                       )
This is a format change and will likely break a ton of programs :/
BTW, could you help to point to any possible tools/programs that would
break other than perf/libtraceevent, because these two are the only
users I run into so far.
Latencytop was the one breaking a few years ago, but there's a metric
ton of sched_switch users out there, this is bound to generate pain.

Steve, you remember what the status of all this was? at the time
breaking this was considered on par with ABI breakage and we reverted or
something. Is this still so?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help