On Mon, 17 Jul 2023 16:51:29 -0700
Alexei Starovoitov [off-list ref] wrote:

On Mon, Jul 17, 2023 at 4:46 PM Masami Hiramatsu [off-list ref] wrote:

quoted

quoted

quoted

+ * Return NULL if not found, or return -EINVAL if parameter is invalid.
+ */
+const struct btf_type *btf_find_func_proto(struct btf *btf, const char *func_name)
+{
+   const struct btf_type *t;
+   s32 id;
+
+   if (!btf || !func_name)
+           return ERR_PTR(-EINVAL);

Please remove these checks.
We don't do defensive programming in the BPF subsystem.
Don't pass NULL pointers to such functions.

OK, we will trust API user to pass a non-NULL parameters.

Thank you!

-- 
Masami Hiramatsu (Google) [off-list ref]