Re: [PATCH v3 1/3] tracing/user_events: Fix incorrect return value for writing operation when events are disable
From: Beau Belgrave <hidden>
Date: 2023-06-22 20:20:50
Also in:
lkml
On Wed, Jun 21, 2023 at 02:08:24PM +0800, sunliming wrote:
The writing operation return the count of writes regardless of whether events are enabled or disabled. Switch it to return 0 to indicates that the event is disabled. Signed-off-by: sunliming <redacted>
This looks good to me. Acked-by: Beau Belgrave <redacted> Thanks!
quoted hunk ↗ jump to hunk
--- kernel/trace/trace_events_user.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c index 1ac5ba5685ed..c085ff829a58 100644 --- a/kernel/trace/trace_events_user.c +++ b/kernel/trace/trace_events_user.c@@ -1957,7 +1957,8 @@ static ssize_t user_events_write_core(struct file *file, struct iov_iter *i) if (unlikely(faulted)) return -EFAULT; - } + } else + return 0; return ret; }-- 2.25.1