Re: [RFC PATCH v4 0/2] trace,smp: Add tracepoints for csd
From: Valentin Schneider <vschneid@redhat.com>
Date: 2023-05-30 10:37:59
Also in:
lkml
From: Valentin Schneider <vschneid@redhat.com>
Date: 2023-05-30 10:37:59
Also in:
lkml
On 15/05/23 15:30, Leonardo Bras wrote:
Changes since RFCv3: - Split the patch in 2: entry/exit and queue - Fix 'struct __call_single_data' & call_single_data_t alignment issue - Made all TP_printk follow the same pattern
One bikeshedding nit I have is I'd prefer to see the csd_* events in a csd trace system, to have a sane nomenclature. Other than that and the other comment on csd_do_func(), this LGTM.
Changes since RFCv2: - Fixed some spacing issues and trace calls Changes since RFCv1: - Implemented trace_csd_queue_cpu() as suggested by Valentin Schneider - Using EVENT_CLASS in order to avoid duplication - Introduced new helper: csd_do_func() - Name change from smp_call_function_* to csd_function_* - Rebased on top of torvalds/master Leonardo Bras (2): trace,smp: Add tracepoints around remotelly called functions trace,smp: Add tracepoints for scheduling remotelly called functions include/trace/events/smp.h | 72 ++++++++++++++++++++++++++++++++++++++ kernel/smp.c | 41 +++++++++++++--------- 2 files changed, 96 insertions(+), 17 deletions(-) create mode 100644 include/trace/events/smp.h -- 2.40.1