Re: [PATCH 11/16] ARM: move setup functions to header
From: Linus Walleij <hidden>
Date: 2023-05-22 07:36:45
Also in:
linux-arm-kernel, linux-pm, lkml
From: Linus Walleij <hidden>
Date: 2023-05-22 07:36:45
Also in:
linux-arm-kernel, linux-pm, lkml
On Tue, May 16, 2023 at 5:46 PM Arnd Bergmann [off-list ref] wrote:
From: Arnd Bergmann <arnd@arndb.de> A couple of functions are declared in arch/arm/mm/mmu.c rather than in a header, which causes W=1 build warnings: arch/arm/mm/init.c:97:13: error: no previous prototype for 'setup_dma_zone' [-Werror=missing-prototypes] arch/arm/mm/mmu.c:118:13: error: no previous prototype for 'init_default_cache_policy' [-Werror=missing-prototypes] arch/arm/mm/mmu.c:1195:13: error: no previous prototype for 'adjust_lowmem_bounds' [-Werror=missing-prototypes] arch/arm/mm/mmu.c:1761:13: error: no previous prototype for 'paging_init' [-Werror=missing-prototypes] arch/arm/mm/mmu.c:1794:13: error: no previous prototype for 'early_mm_init' [-Werror=missing-prototypes] Move the declaratsion to asm/setup.h so they can be seen by the compiler while building the definition. Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This looks cleaner to me: Reviewed-by: Linus Walleij <redacted> Yours, Linus Walleij