On Tue, Mar 28, 2023 at 05:37:40PM -0400, Steven Rostedt wrote:

On Tue, 28 Mar 2023 17:32:00 -0400
Steven Rostedt [off-list ref] wrote:

quoted

quoted

+static long user_events_ioctl_unreg(unsigned long uarg)
+{
+	struct user_unreg __user *ureg = (struct user_unreg __user *)uarg;
+	struct user_event_mm *mm = current->user_event_mm;
+	struct user_event_enabler *enabler, *next;
+	struct user_unreg reg;
+	long ret;
+
+	ret = user_unreg_get(ureg, &reg);
+
+	if (ret)
+		return ret;
+
+	if (!mm)
+		return -ENOENT;
+
+	ret = -ENOENT;  

Probably should add:

	if (reg.__reserved || reg.__reserved2)
		return -EINVAL;

here.

Nice catch! Yes I'll add this.

I finished my review.

Can to send a v10 out with this update, and also update all the structs to
have the fields tabbed out for easier reading.

Yep will do, I will have the tabbed out changes in a isolated patch in
the v10 series.

Thanks,
-Beau

Thanks!

-- Steve