Re: [PATCH] ftrace: set direct_ops storage-class-specifier to static
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Date: 2023-03-15 08:48:53
Also in:
lkml
On Sat, 11 Mar 2023 08:51:13 -0500 Tom Rix [off-list ref] wrote:
smatch reports this warning kernel/trace/ftrace.c:2594:19: warning: symbol 'direct_ops' was not declared. Should it be static? The variable direct_ops is only used in ftrace.c, so it should be static Signed-off-by: Tom Rix <trix@redhat.com>
This looks good to me. Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> Thank you!
quoted hunk ↗ jump to hunk
--- kernel/trace/ftrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 29baa97d0d53..05f76dc1f0c5 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c@@ -2591,7 +2591,7 @@ static void call_direct_funcs(unsigned long ip, unsigned long pip, arch_ftrace_set_direct_caller(fregs, addr); } -struct ftrace_ops direct_ops = { +static struct ftrace_ops direct_ops = { .func = call_direct_funcs, .flags = FTRACE_OPS_FL_DIRECT | FTRACE_OPS_FL_SAVE_REGS | FTRACE_OPS_FL_PERMANENT,-- 2.27.0
-- Masami Hiramatsu (Google) [off-list ref]