Re: [PATCH v10 03/13] kbuild: add tristate checker

From
Masahiro Yamada <masahiroy@kernel.org>
Date
2023-03-05 15:11:09
Also in
linux-modules, lkml
Reply to
Nick Alcock, 2022-12-05
On Tue, Dec 6, 2022 at 1:32 AM Nick Alcock [off-list ref] wrote:
This new check target uses the tristate.conf machinery just added, and
modules.builtin.objs, to identify source files that have MODULE_*
declarations despite not being modules according to Kconfig.  After
commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), all such declarations will cause
modprobe to misidentify their containing object file as a module when it
is not, which might cause it to spuriously fail when trying to load
something that is built in to the kernel.



Having false-positives in modules.builtin should be OK.


Also, scripts/check-tristates.mk is just a rename of
scripts/Makefile.modbuiltin.


NACK.





--
Best Regards


Masahiro Yamada
Thread (27 messages) 27 messages, 9 authors, last reply 2023-05-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help