Re: [PATCH 5/8] ftrace: Make DIRECT_CALLS work WITH_ARGS and !WITH_REGS
From: Florent Revest <hidden>
Date: 2023-02-02 18:18:22
Also in:
bpf, linux-arm-kernel, lkml
From: Florent Revest <hidden>
Date: 2023-02-02 18:18:22
Also in:
bpf, linux-arm-kernel, lkml
On Thu, Feb 2, 2023 at 4:54 PM Mark Rutland [off-list ref] wrote:
On Wed, Feb 01, 2023 at 05:34:17PM +0100, Florent Revest wrote:quoted
Direct called trampolines can be called in two ways: - either from the ftrace callsite. In this case, they do not access any struct ftrace_regs nor pt_regs - Or, if a ftrace ops is also attached, from the end of a ftrace trampoline. In this case, the call_direct_funcs ops is in charge of setting the direct call trampoline's address in a struct ftrace_regs Since "ftrace: pass fregs to arch_ftrace_set_direct_caller()", the later case no longer requires a full pt_regs.Minor nit, but could we please have the commit ID, e.g. | Since commit: | | 9705bc70960459ae ("ftrace: pass fregs to arch_ftrace_set_direct_caller()") | | The latter case no longer requires a full pt_regs.
Sure thing, will do!