Re: [PATCH 4/4] tracing: Allow boot instances to have snapshot buffers

Hi Steven,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on linus/master v6.2-rc3 next-20230111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Steven-Rostedt/tracing-Add-creation-of-instances-at-boot-command-line/20230111-230425
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20230111145842.847715402%40goodmis.org
patch subject: [PATCH 4/4] tracing: Allow boot instances to have snapshot buffers
config: arc-defconfig
compiler: arc-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/b4515aa1407184147348b74b42bf10af90b905e7
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Steven-Rostedt/tracing-Add-creation-of-instances-at-boot-command-line/20230111-230425
        git checkout b4515aa1407184147348b74b42bf10af90b905e7
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot [off-list ref]

All errors (new ones prefixed by >>):

   kernel/trace/trace.c: In function 'enable_instances':

quoted

kernel/trace/trace.c:10244:25: error: implicit declaration of function 'do_allocate_snapshot'; did you mean 'boot_alloc_snapshot'? [-Werror=implicit-function-declaration]

   10244 |                         do_allocate_snapshot(tok);
         |                         ^~~~~~~~~~~~~~~~~~~~
         |                         boot_alloc_snapshot
   cc1: some warnings being treated as errors


vim +10244 kernel/trace/trace.c

 10227	
 10228	__init static void enable_instances(void)
 10229	{
 10230		struct trace_array *tr;
 10231		char *curr_str;
 10232		char *str;
 10233		char *tok;
 10234	
 10235		/* A tab is always appended */
 10236		boot_instance_info[boot_instance_index - 1] = '\0';
 10237		str = boot_instance_info;
 10238	
 10239		while ((curr_str = strsep(&str, "\t"))) {
 10240	
 10241			tok = strsep(&curr_str, ",");
 10242	
 10243			if (IS_ENABLED(CONFIG_TRACER_MAX_TRACE))
 10244				do_allocate_snapshot(tok);
 10245	
 10246			tr = trace_array_get_by_name(tok);
 10247			if (!tr) {
 10248				pr_warn("Failed to create instance buffer %s\n", curr_str);
 10249				continue;
 10250			}
 10251			/* Allow user space to delete it */
 10252			trace_array_put(tr);
 10253	
 10254			while ((tok = strsep(&curr_str, ","))) {
 10255				early_enable_events(tr, tok, true);
 10256			}
 10257		}
 10258	}
 10259	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests