Thread (6 messages) 6 messages, 3 authors, 2022-12-09

Re: [PATCH v2] tracing: Add trace_trigger kernel command line option

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2022-12-08 23:42:38
Also in: lkml

On Thu, 8 Dec 2022 15:27:07 -0700
Ross Zwisler [off-list ref] wrote:
quoted
+#ifdef CONFIG_HIST_TRIGGERS  
Can you help me understand why this is only available if
CONFIG_HIST_TRIGGERS is selected in the kernel config?  AFAICT this
code doesn't depend on the histogram code, and the run-time selection
of triggers is usable without CONFIG_HIST_TRIGGERS.
Good catch!

I got confused, and only saw that as "CONFIG_TRIGGERS" and wasn't thinking
that config was just for histogram triggers :-p

Care to send a patch to fix it?

Thanks Ross,

-- Steve
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help