reorganize trace_peobe_tmpl.h

Started by Song Chen on Nov 23, 2022

DORMANTno replies SUPERSEDED

Status: Superseded by v5 (posted 2022-12-30). [go to v5]

Revision v2 (4 revisions archived).

Revisions (4)
  1. v2 current
  2. v3 [diff against previous]
  3. v4 [diff against previous]
  4. v5 [diff against previous]

open the first message on its own page

Message details and related content
Hi,

In the first patchset, my intension was to remove trace_probe_tmpl.h,
just keep a unified process_fetch_insn and process_fetch_insn_bottom
in trace_probe.c for all *probes. is_uprobe was the most important
move to approach. If it was not accepted, the whole patchset couldn't
stand.

Then I change my goal to at least no warnings or errors when impelenting
a new feature based on trace probe if it includes trace_probe_tmpl.h by
provideing default behaviors. What's more, it also removes redundant
code in kprobe and eprobe.

Song Chen (2):
  kernel/trace: Introduce trace_probe_print_args and use it in *probes
  kernel/trace: Provide default impelentations defined in
    trace_probe_tmpl.h

 kernel/trace/trace_eprobe.c       | 146 +-----------------------------
 kernel/trace/trace_events_synth.c |   7 +-
 kernel/trace/trace_kprobe.c       | 106 +---------------------
 kernel/trace/trace_probe.c        |  27 ++++++
 kernel/trace/trace_probe.h        |   2 +
 kernel/trace/trace_probe_kernel.h | 140 ++++++++++++++++++++++++++--
 kernel/trace/trace_probe_tmpl.h   |  28 ------
 kernel/trace/trace_uprobe.c       |   2 +-
 8 files changed, 171 insertions(+), 287 deletions(-)

-- 
2.25.1
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help