Thread (25 messages) flat view 25 messages, 9 authors, 2021-11-25

Re: [PATCH 20/22] x86,word-at-a-time: Remove .fixup usage

From: Miroslav Benes <mbenes@suse.cz>
Date: 2021-11-15 12:59:56
Also in: live-patching, lkml, llvm

On Fri, 12 Nov 2021, Josh Poimboeuf wrote:
If the child schedules out, and then the parent gets patched, things can
go off-script if the child later jumps back to the unpatched version of
the parent, and then for example the old parent tries to call another
patched function with a since-changed ABI.
...
 
I don't know about other patch creation tooling, but I'd imagine they
also need to know about .cold functions, unless they have that
optimization disabled.  Because the func and its .cold counterpart
always need to be patched together.
We, at SUSE, solve the issue differently... the new patched parent would 
call that another patched function with a changed ABI statically in a live 
patch. So in that example, .cold child would jump back to the unpatched 
parent which would then call, also, the unpatched function.

The situation would change if we ever were to have some notion of global 
consistency. Then it would be really fragile, so it is worth of improving 
this, I think.

Miroslav
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help