Thread (16 messages) 16 messages, 5 authors, 2021-12-15

Re: [PATCH 2/2] i2c: tegra: Add SMBus block read and SMBus alert functions

From: Dmitry Osipenko <digetx@gmail.com>
Date: 2021-12-11 20:12:47
Also in: linux-devicetree, linux-i2c, lkml

10.12.2021 12:38, Akhil R пишет:
quoted
Although, you shouldn't need it at all, use devm_gpiod_get_optional().
smbus-alert is provided in the i2c dt bindings by default. I felt it is good
to put it into use since the use case is same.
My point is that you don't need to use device_property_read_bool().

Instead, you could use devm_gpiod_get_optional() and check whether
returned GPIO is ERR or NULL (not present). Which could be a bit nicer
variant.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help