On 10/25/2021 6:28 PM, Jaroslav Kysela wrote:

On 25. 10. 21 13:06, Sameer Pujar wrote:

quoted

@@ -150,11 +186,22 @@ static int tegra210_mvc_put_mute(struct 

snd_kcontrol *kcontrol,

...

quoted

      return 1;

It's a bit unrelated comment to this change, but it may be worth to 
verify all
kcontrol put callbacks in the tegra code. Ensure that value 1 is 
returned only
when something was really changed in hardware.

The tegra210_i2s_put_control() has opposite problem for example - returns
always 0 which means that the change notifications are not send to 
subscribed
applications.

Thanks Jaroslav for review. I will keep a note to review put() calls in 
Tegra drivers and send fixes accordingly.