Re: [PATCH v6 6/6] iommu/tegra-smmu: Add pagetable mappings to debugfs
From: Dmitry Osipenko <digetx@gmail.com>
Date: 2021-09-14 13:29:21
Also in:
linux-iommu, lkml
14.09.2021 04:38, Nicolin Chen пишет:
quoted hunk ↗ jump to hunk
+static unsigned long pd_pt_index_iova(unsigned int pd_index, unsigned int pt_index) +{ + return ((dma_addr_t)pd_index & (SMMU_NUM_PDE - 1)) << SMMU_PDE_SHIFT | + ((dma_addr_t)pt_index & (SMMU_NUM_PTE - 1)) << SMMU_PTE_SHIFT; +}
We know that IOVA is fixed to u32 for this controller. Can we avoid all these dma_addr_t castings? It should make code cleaner a tad, IMO.