Re: [PATCH v4 13/27] drm/mediatek: Don't set struct drm_device.irq_enabled
From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date: 2021-08-09 13:09:14
Also in:
amd-gfx, dri-devel, intel-gfx, linux-mediatek, linux-samsung-soc, linux-sunxi, nouveau
Hi, Thomas: Thomas Zimmermann [off-list ref] 於 2021年6月25日 週五 下午4:22寫道：
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in mediatek.
Acked-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
quoted hunk ↗ jump to hunk
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by: Daniel Vetter <redacted> --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 ------ 1 file changed, 6 deletions(-)diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index b46bdb8985da..9b60bec33d3b 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c@@ -270,12 +270,6 @@ static int mtk_drm_kms_init(struct drm_device *drm) goto err_component_unbind; } - /* - * We don't use the drm_irq_install() helpers provided by the DRM - * core, so we need to set this manually in order to allow the - * DRM_IOCTL_WAIT_VBLANK to operate correctly. - */ - drm->irq_enabled = true; ret = drm_vblank_init(drm, MAX_CRTC); if (ret < 0) goto err_component_unbind; --2.32.0