答复: [PATCH v2 02/22] drm/hibmc: Call drm_irq_uninstall() unconditionally
From: "tiantao (H)" <tiantao6@hisilicon.com>
Date: 2021-06-23 14:38:09
Also in:
amd-gfx, dri-devel, linux-mediatek, linux-samsung-soc, nouveau
Subsystem:
drm drivers, drm drivers and misc gpu patches, the rest · Maintainers:
David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Linus Torvalds
-----邮件原件----- 发件人: Thomas Zimmermann [mailto:tzimmermann@suse.de] 发送时间: 2021年6月22日 22:10 收件人: daniel@ffwll.ch; airlied@linux.ie; alexander.deucher@amd.com; christian.koenig@amd.com; Xinhui.Pan@amd.com; james.qian.wang@arm.com; liviu.dudau@arm.com; mihail.atanassov@arm.com; brian.starkey@arm.com; maarten.lankhorst@linux.intel.com; mripard@kernel.org; inki.dae@samsung.com; jy0922.shim@samsung.com; sw0312.kim@samsung.com; kyungmin.park@samsung.com; krzysztof.kozlowski@canonical.com; xinliang.liu@linaro.org; tiantao (H) [off-list ref]; john.stultz@linaro.org; kongxinwei (A) [off-list ref]; Chenfeng (puck) [off-list ref]; laurentiu.palcu@oss.nxp.com; l.stach@pengutronix.de; p.zabel@pengutronix.de; shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; linux-imx@nxp.com; chunkuang.hu@kernel.org; matthias.bgg@gmail.com; bskeggs@redhat.com; tomba@kernel.org; hjc@rock-chips.com; heiko@sntech.de; benjamin.gaignard@linaro.org; yannick.fertre@foss.st.com; philippe.cornu@foss.st.com; mcoquelin.stm32@gmail.com; alexandre.torgue@foss.st.com; wens@csie.org; jernej.skrabec@gmail.com; thierry.reding@gmail.com; jonathanh@nvidia.com; jyri.sarha@iki.fi; emma@anholt.net; linux-graphics-maintainer@vmware.com; zackr@vmware.com; hyun.kwon@xilinx.com; laurent.pinchart@ideasonboard.com; michal.simek@xilinx.com 抄送: amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-mediatek@lists.infradead.org; nouveau@lists.freedesktop.org; linux-rockchip@lists.infradead.org; linux-stm32@st-md-mailman.stormreply.com; linux-sunxi@lists.linux.dev; linux-tegra@vger.kernel.org; Thomas Zimmermann [off-list ref] 主题: [PATCH v2 02/22] drm/hibmc: Call drm_irq_uninstall() unconditionally Remove the check around drm_irq_uninstall(). The same test is done by the function internally. The tested state in irq_enabled is considered obsolete and should not be used by KMS drivers. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Acked-by: Tian Tao <tiantao6@hisilicon.com>
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
index f4bc5386574a..f8ef711bbe5d 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c@@ -253,8 +253,7 @@ static int hibmc_unload(struct drm_device *dev) { drm_atomic_helper_shutdown(dev); - if (dev->irq_enabled) - drm_irq_uninstall(dev); + drm_irq_uninstall(dev); pci_disable_msi(to_pci_dev(dev->dev)); --
2.32.0